MoveInstanceMethodRefactoring is not yet fully OT-aware

[stephan]

In testclass org.objectteams.otdt.ui.tests.refactoring.move.MoveInstanceMethodTests 17 tests are still disabled, because refactoring implementation is not yet completed here.

[jogeb]

By adding a overloading and ambiguity check, 6 tests could be fixed. The other 11 tests are still disabled. The checks are implemented in the team org.objectteams.otdt.refactoring.adaptor.MoveInstanceMethodAdaptor.

The JDT's MoveInstanceMethodProcessor does only check a few preconditions. Therefore a lot of pure Java checks need to be implemented in the MoveInstanceMethodAdaptor.

[stephan]

Removing keyword junitfailure, because the affected test is not part of the Eclispe JUnit suite.

[stephan]

Replying to jogeb:

The JDT's MoveInstanceMethodProcessor does only check a few preconditions. Therefore a lot of pure Java checks need to be implemented in the MoveInstanceMethodAdaptor.

For cross reference: two such missing checks are reported as

• Eclipse bug 286221 -- this one is fixed upstream
  • 3.6.0 M3 (and earlier?) indeed contains the fix
  • -> to what degree does it help for the tests at in this issue?
• Eclipse bug 286224 -- this one is still open
  • -> we should watch for any activity there.

Are there any other tests missing in the JDT that are needed for our tests?

[stephan]

Update: only 9 tests in MoveInstanceMethodAdaptor are left disabled.

This ticket has now moved to Eclipse bug 286224, won't be fixed from objectteams.org.