Ticket #76 (closed defect: wontfix)

Opened 3 years ago

Last modified 5 months ago

Rename method of generic type misses one method

Reported by: stephan Owned by:
Priority: major Milestone: OTDT_2.0.0
Component: refactoring Version: 1.1.6
Keywords: junitfailure Cc:

Description (last modified by stephan) (diff)

Tests #testGenerics1 and #testGeneric3 in org.eclipse.jdt.ui.tests.refactoring.RenameVirtualMethodInClassTests fail to rename one method reference.
See:

These refactorings require the RippleMethodFinder2 which has not yet been integrated with the OT/J (needs RegionBasedOTHierarchy).

Disabling these two tests for now.

Change History

Changed 3 years ago by stephan

  • owner stephan deleted
  • component changed from compiler to refactoring

Changed 10 months ago by jogeb

The RippleMethodFinder2 works already with the standard OTTypeHierarchy. To get a better support for OT/J programs, the OTHierarchy is used instead of the JDT's RegionBasedHierarchy. The test #test07 in org.eclipse.jdt.ui.tests.refactoring.IntroduceIndirectionTests has to be disabled, because the RippleMethodFinder2 using the OTTypeHierarchy misses one method occurrence.

The other Tests #testGenerics1 and #testGeneric3 can be enabled again.

The development of a RegionBasedOTHierarchy requires the implementation of a new RegionBasedOTHierarchyBuilder. A simple solution that tried to use inheritence like the JDT's RegionBasedHierarchyBuilder did not work, because the OTTypeHierarchyBuilder does not extend the JDT HierarchyBuilder and uses its own build strategy.

Changed 9 months ago by stephan

  • description modified (diff)

After the fix for #330 two tests in IntroduceIndirectionTests toggled behavior:

  • test07 now passes (re-enabled)
  • test24 now fails (disabled)

Changed 5 months ago by stephan

  • status changed from new to closed
  • resolution set to wontfix

This ticket has moved to Eclipse bug 310874 (won't be fixed from objectteams.org)

Note: See TracTickets for help on using tickets.