Ticket #261 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Link with editor doesn't work when showing logical structure

Reported by: stephan Owned by: stephan
Priority: major Milestone: OTDT_1.3.0_M4
Component: jdt.ui.adaptor Version: 1.3.0M3
Keywords: Cc:

Description

Using OTSample-FlightBonus, switch the package explorer to showing roles files logically, open class FlightBonusDialog in the editor (either variant) and hit "link with Editor" in the package explorer.

The package explorer will not find the role file to select.

Change History

Changed 3 years ago by stephan

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from OTDT_1.3.0 to OTDT_1.3.0_M4

Fixed in r21645.

The original problem was fixed by a rewrite of ContentProvider.getParent():

  • intercept PackageExplorerPart.showInput so that a role file compilation unit is not used as the input when in logical package mode, but the role file type is used instead.
  • lookup of a role files parent must travel to the team type instead of the enclosing CU - this is needed to find tree paths to a given element

While implementing this I found some apparently unused code dating back to TPX-27 (updating issues in the package explorer when creating a new package etc.). Removed.

Another issue was found when creating a role file while in logical mode: an update was fired to display the newly created team package. This update is now blocked by intercepting PackageExplorerProblemTreeViewer.add(Object,Object).

Note: See TracTickets for help on using tickets.