Ticket #240 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Warn about "playedBy FQN"

Reported by: stephan Owned by: stephan
Priority: minor Milestone: OTDT_1.3.0_M3
Component: compiler Version: 1.2.7
Keywords: Cc:

Description

In OT-Plugin projects the compiler checks that all base classes be actually imported using a base import. (Regular OT/J projects just flag this as a warning).

Using the base class's fully qualified name allows to bypass this check. We'd probably want to flag "playedBy FQN" at the same severity as using a regularly imported class as the base class.

(and expect many test to fail because of a new warning ...)

Change History

Changed 4 years ago by stephan

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to OTDT_1.3.0_M3

Test is in 2.1.10-otjld-base-import-8.

Implementation is in r21555.

Changed 4 years ago by stephan

r21566 fixes regressions in similar-looking cases that should not trigger this warning.

Additionally, r21556 provides a quickfix against this warning. Note that to-date the quickfix does not work for role files because that would require to change two files at the same time. I couldn't find another quickfix that does this..

Changed 4 years ago by stephan

Implementation of the quickfix is completed in r21588: works for role files, too, and actually modifies two compilation units by a single quickfix. Includes test.

Note: See TracTickets for help on using tickets.