Ticket #196 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Support quickfix for correcting the visibility of a callout

Reported by: stephan Owned by: stephan
Priority: critical Milestone: OTDT_1.2.6
Component: content assist Version: 1.2.5
Keywords: Cc:

Description

Since role method visibility is now strictly enforced (#194) and callout binding are now allowed to specify visibility in shorthand syntax, the quickfix for invisible methods should be extended to cover extending the visibility of a callout, too.

This is important because before #194 client code could contain illegal references (violating OTJLD §1.2.1(e)), which is now uncompilable. Using the quickfix clients should be able to quickly fix their code.

At a closer look, even fixing the visibilty of normal role methods is not currently integrated in the existing quickfix, because we use a different problem ID (NotVisibleRoleMethod vs. NotVisibleMethod). This should be corrected, too.

Change History

Changed 4 years ago by stephan

r19526 basically implements this feature.

It already proved useful in updating some OT-plugins of the OTDT.

Yet, leaving the issue open until -we have some tests, -it has been used to update all of the OTDT.

Changed 4 years ago by stephan

  • status changed from new to closed
  • resolution set to fixed

Implementation is improved in r19527, including the scenario where the callout is invoked via an externalized role -> need to make it public. This changeset also includes tests.

r19536 extends the feature to apply to quickfixes across compilation units (i.e., change a file that's not the currently active editor).

Also r19539 is related: quickfix for adjusting method visibility to the visibility of an overridden method is extended to apply to tsuper overriding, too.

OTDT has been migrated using these quickfixes (committed as r19538).

This closes this issue.

Note: See TracTickets for help on using tickets.