Ticket #137 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Revise launch configurations for OT/J

Reported by: stephan Owned by: stephan
Priority: major Milestone: OTDT_1.2.2
Component: debug Version: 1.2.0
Keywords: Cc:

Description

Instead of providing new launch configuration types for all kinds of OT/J programs (Java Application, JUnit, Eclipse Application ..) we should perhaps just offer a check box for all of those launch types for enabling OT/J.

Change History

Changed 5 years ago by mosconi

Additionally, we could provide a consistent Team Activation tab for the different launch types.

Changed 5 years ago by stephan

  • owner set to stephan
  • status changed from new to assigned

Initial implementation is in r18844:

No longer need to create launch configurations of OT-specific types, but for all Java and JUnit launches (others will follow) the JRE-tab now contains a new subsection with a checkbox "Enable OTRE".

For projects with the OTJavaNature, this checkbox is enabled by default.

Old launch configuration types are still supported but we may want to fade out those. Should decide whether any migration aid is necessary here.

Re comment 1: the Team Activation tab only applies to Java applications (OT/Equinox defines this by the aspectBinding extensions). But yes, we should add the Team Activation tab to launches like JUnit, too. Should the "Enable OTRE" checkbox then migrate to the Team Activation tab? OTOH, also Equinox-launches have a JRE section and that's where I would add "Enable OTRE" for those launches, consistently grouping JRE and OTRE.

Changed 5 years ago by stephan

r18856 addresses the Team Activation tab, which now is uniformly added to the dialog for Java/JUnit launches iff the current project has the OTJavaNature.

Note: This patch requires a compiler as of r18849 (plus r18850, r18854).

Changed 5 years ago by stephan

  • milestone set to OTDT_1.2.2

Changed 5 years ago by stephan

Second part (regarding pde-launches with/without OT/Equinox) is implemented as a single team (PDEUILaunchingAdaptor) in r18887. The "Object Teams Runtime" block always appears next to the JRE block in the launch configuration dialog. For Eclipse Applications this is the main tab, for OSGi launches the "OSGi settings" tab.

Note that half the classes in org.objectteams.pde.ui are now legacy and can be removed once we can migrate old launch configurations to the new scheme.

Changed 5 years ago by stephan

  • status changed from assigned to closed
  • resolution set to fixed

Changed 5 years ago by stephan

r18907 extends the implementation of this issue to apply to JUnit-Plugin launches, too.

Note, that these launches inherit from standalone JUnit (=Java Application) launches, rather than from PDE launches, which required a few adjustments:

  • different signature of getVMArguments (String vs. String[])
  • possible interference with (undesired) launching via JMangler
Note: See TracTickets for help on using tickets.