Ticket #120 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Quickfix for role constructor visibility doesn't work

Reported by: stephan Owned by: stephan
Priority: major Milestone: OTDT_1.2.1
Component: content assist Version: 1.2.0pre
Keywords: Cc:

Description

If a role constructor is not visible, a quickfix is offered to change the visibility of the creation method, which then of course produces no text changes.

I observed this in PDEAdaptor regarding the ctor of Rule.

Change History

Changed 5 years ago by stephan

  • milestone changed from OTDT_1.2.0 to OTDT_1.2.1

Changed 5 years ago by stephan

  • status changed from new to closed
  • resolution set to fixed

Tests and fix are in r18800:

Covers these situations:

  • role ctor/method needing protected visibility for access from the same team
  • role ctor/method needing public visibility (externalized role, which is a different IProblem)
  • works across file boundaries (i.e., also from/to role files)

Includes a patch for QualifiedAllocationExpression, which must store not only the resolvedType but also the binding (MethodBinding) from the deeply contained MessageSend.

Note: See TracTickets for help on using tickets.